Tests: add regression tests for FilterRange with zero value#1275
Merged
Tests: add regression tests for FilterRange with zero value#1275
Conversation
Verify that '0' is correctly treated as a valid filter value in FilterRange, not skipped as if no filter was provided.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1275 +/- ##
=======================================
Coverage 46.79% 46.79%
=======================================
Files 53 53
Lines 2729 2729
=======================================
Hits 1277 1277
Misses 1452 1452 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #730
Summary
ArraysHelper::testEmptyhandles'0'and all data sourceapplyFilterRangeimplementations use!== ''oris_numeric()), but no regression tests existedtestFilterRangeWithZeroToValuetoBaseDataSourceTest— runs against all 7 data sources; setsto = '0'and expects empty results (all ages in test data are > 0, so if the filter were ignored it would return all 6 records)testFilterRangeWithZeroFromValuetoArrayDataSourceTest— uses a custom dataset with negative/zero/positive values; setsfrom = '0'and expects 2 results (age ≥ 0)Test plan
make testspasses (29 tests, 0 failures)